Repository navigation
fix(gitlab): find merge requests opened from a fork - #40894
juliusmarminge merged 4 commits into
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Listing a branch's merge requests from the upstream itself looked up every fork's source project, one glab call each, though none of them can match. GitLab's head probe now keeps the owner-qualified selector GitManager sends first for a fork head, and only that list resolves source project ids, once per distinct id and concurrently. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
EvidenceCreated a real GitLab fork MR from feature/x into upstream main. Opened the same branch in fresh web app state on both commits and invoked create_pr. Base missed the MR; head displayed it and returned opened_existing. Chromium, 1280×800, light theme, replay-agent history.
Limitation: base's Create MR action stopped at disabled text generation, so the original duplicate-MR error was not captured. Discovery failure and head's reuse result were verified. Not shown:
|
Co-authored-by: Abhiram-745 <237478249+Abhiram-745@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
**v0.1.12-nightly.20261122.5111** · 30 changes from 10 contributors - **Multi-file diffs.** Open diff now shows every file in a multi-file Codex patch. - **Mixed-content paste.** Pasting a message with text and a picture now keeps both. - **Queued attachments.** Edit a queued message without losing its image or file attachment chips. - **Pull request checks.** Agents watching a pull request can recognize checks that already passed instead of waiting indefinitely. - **Notebook outputs.** Saved HTML outputs now appear when you scroll them into view. ### Plus 24 more bug fixes and performance improvements. <details> <summary>Full changelog</summary> ## What's Changed * perf(mobile): keep image bytes outside draft JSON by @t3dotgg in pingdotgg/t3code#9727 * fix(server): watch_pull_request says when checks already passed by @juliusmarminge in pingdotgg/t3code#40866 * fix(codex): Open diff shows every file of a multi-file patch by @Abhiram-745 in pingdotgg/t3code#40874 * fix(server): ACP startup gives up when the agent never answers the handshake by @juliusmarminge in pingdotgg/t3code#40864 * fix(server): a branch prefixed with another remote's name publishes under its full name by @Abhiram-745 in pingdotgg/t3code#40877 * fix(server): list open delegated tasks when task_status or task_cancel finds no match by @Project516 in pingdotgg/t3code#40886 * fix(gitlab): find merge requests opened from a fork by @Abhiram-745 in pingdotgg/t3code#40894 * fix(web): pasting a chat message with text and a picture keeps both by @juliusmarminge in pingdotgg/t3code#40909 * fix(antigravity): bound silent post-settle background command holds by @Lokkuchakreshkumar in pingdotgg/t3code#40858 * fix(desktop): WSL is not offered or started when only the Windows install stub exists by @juliusmarminge in pingdotgg/t3code#40918 * fix(server): idle /ws connections behind a reverse proxy no longer drop every 60s by @juliusmarminge in pingdotgg/t3code#40932 * fix(server): thread reads no longer attribute T3 Code's compact-before-send /compact to the user by @juliusmarminge in pingdotgg/t3code#40934 * fix(web,mobile): @-file mentions show by name in message previews, not as raw links by @tiliakoos in pingdotgg/t3code#40924 * fix(web): tool calls stay grouped after a usage-limit pause again by @matthew-waters in pingdotgg/t3code#40905 * fix(server): t3 doctor no longer reports a database just under 1 GiB as "1024.0 MiB" by @tiliakoos in pingdotgg/t3code#40952 * fix(web): show clone failure after progress is dismissed by @StiensWout in pingdotgg/t3code#40951 * Invalidate pending theme imports when a replacement is too large by @StiensWout in pingdotgg/t3code#40965 * fix(mobile): show linked thread history page errors by @StiensWout in pingdotgg/t3code#40973 * fix(client-runtime): skip waiting for lower-priority linked addresses by @StiensWout in pingdotgg/t3code#40989 * fix(web): navigate Excel sheets from the focused tab by @StiensWout in pingdotgg/t3code#41008 * fix(mobile): bound app-owned composer attachment filenames by @StiensWout in pingdotgg/t3code#40991 * fix(web): prioritize visible saved notebook outputs by @StiensWout in pingdotgg/t3code#40998 * fix(web): editing a queued message keeps its attachment chips resolved by @smirea in pingdotgg/t3code#40945 * fix(server): unlinking an environment ends its session on the other machine by @juliusmarminge in pingdotgg/t3code#41005 * fix(mobile): scope Git result banners to their originating thread by @StiensWout in pingdotgg/t3code#41015 * fix(web): keep the conversation when a pairing tab closes by @StiensWout in pingdotgg/t3code#41025 * fix: restart linked thread reads when trying again by @StiensWout in pingdotgg/t3code#41020 * fix(client-runtime): count ambiguous projects in chat file links by @StiensWout in pingdotgg/t3code#40986 * fix(mobile): keep media actions on each sent image page by @StiensWout in pingdotgg/t3code#41018 * perf(server): a run's provider turn lookup is linear, not quadratic by @navidnadali in pingdotgg/t3code#38791 ## New Contributors * @Lokkuchakreshkumar made their first contribution in pingdotgg/t3code#40858 * @matthew-waters made their first contribution in pingdotgg/t3code#40905 **Full Changelog**: pingdotgg/t3code@v0.1.12-nightly.20261122.5098...v0.1.12-nightly.20261122.5111 </details> Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.12-nightly.20261122.5111


Problem
On GitLab, T3 Code never finds a merge request opened from a fork.
Repro on
main:originis the upstream (group/upstream), and add your fork as another remote (alice/upstream).feature/x, push it to the fork, and open a merge request into the upstream project (from T3 Code or the GitLab UI).GitLabCli.listMergeRequestsrunsglab mr list --source-branch <branch> --output json. glab prints GitLab's merge request list rows (client-goBasicMergeRequest), which name the source project only bysource_project_id. There is nosource_projectobject in that output, and the GitLab MR API docs list none.normalizeGitLabMergeRequestRecordreadsraw.source_project, so a fork MR comes back withisCrossRepository: truebut noheadRepositoryNameWithOwnerorheadRepositoryOwnerLogin.matchesBranchHeadContextinGitManager.tsthen rejects every cross-repository MR whose head has neither, so both the status lookup and the existing-MR check before create miss it. The existing tests pass only because their fixtures include asource_projectfield that glab doesn't print.Change
GitLabClilooks the project up once withglab api projects/<source_project_id>and fillsheadRepositoryNameWithOwnerandheadRepositoryOwnerLoginfrom itspath_with_namespace, using the existing owner rule.source_project, cause no extra glab call and come out unchanged.Scope
This is a focused fix for an obvious bug in the GitLab adapter, so I didn't open an issue. #29791 made GitLab read a full page so
GitManager's owner matching could pick the branch's own MR out of fork MRs, but that matching needs the source project, which real glab output doesn't include. #23439 changed fork MR creation, not the lookup.Verification
GitLabSourceControlProvider.git.test.ts, "names a fork merge request's source project from real glab list output". It lists four MRs in the real glab shape: two forks from one project, one same-project MR, and a fork whose project lookup returns bad JSON. Onmainit fails withexpected [ { provider: 'gitlab', …(11) }, …(3) ] to match object [ { number: 1, …(3) }, …(3) ]. With the fix it passes, and it asserts the onlyglab apicalls areprojects/101andprojects/102: one per project, none for the same-project MR.packages/source-control-gitlabpasses (296 tests).apps/serverGitManager.test.tspasses (160 tests).vp fmt,vp lintandknip:checkon the changed files are clean, and the package typecheck passes.mr listJSON (client-goBasicMergeRequest) and the GitLab merge request API docs.Code written with Claude Code (Claude Opus 5.5).